From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: pg_dump dumps event triggers and transforms unconditionally |
Date: | 2016-01-12 22:13:30 |
Message-ID: | 12189.1452636810@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> AFAICT event triggers don't belong to any particular schema, so I'd
>> propose that they be dumped only when include_everything is true,
>> which is the usual rule for objects that don't belong to any schema.
>>
>> Transforms have got the same issue, which means that the dump of a
>> database containing, eg, hstore_plperl is outright broken: it will
>> dump both the extension *and* a CREATE TRANSFORM command. Again, they
>> ought to obey the default rules for schema-less objects, which in
>> this case is "dump if include_everything and not an extension member".
> Sounds reasonable. (I assume this last detailed rule is what applies to
> both object types. Surely event triggers can be part of an extension
> too.)
Don't know offhand if they can or not, but the code will do the right
thing if so.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-01-12 22:17:56 | Re: WIP: Rework access method interface |
Previous Message | Adam Brightwell | 2016-01-12 22:13:11 | Re: bootstrap pg_shseclabel in relcache initialization |