Re: pgsql: Fix CreatePolicy, pg_dump -v; psql and doc updates

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix CreatePolicy, pg_dump -v; psql and doc updates
Date: 2014-10-03 22:06:13
Message-ID: 12184.1412373973@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> Fix CreatePolicy, pg_dump -v; psql and doc updates

Just as a note, this should've included a catversion bump. The rule of
thumb is that if you need to do an initdb (not just a recompile) to get
the regression tests to pass, there should be a catversion bump. And
that applies here, because the old system_views definition won't match
rules.out.

It's not important enough to go back and change catversion.h now, but
please keep it in mind for the future. One of the main values of
catversion is to prevent developers from wasting time chasing regression
test failures that are just code-vs-data-skew issues.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2014-10-03 22:14:47 Re: pgsql: Fix CreatePolicy, pg_dump -v; psql and doc updates
Previous Message Tom Lane 2014-10-03 21:46:29 pgsql: Update time zone abbreviations lists.