From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Martin Zaun <Martin(dot)Zaun(at)Sun(dot)COM>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Greg Smith <gsmith(at)gregsmith(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Bruce Momjian <bruce(at)momjian(dot)us>, Dave Page <dpage(at)pgadmin(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS]odd output in restore mode |
Date: | 2008-08-02 10:07:49 |
Message-ID: | 1217671669.3934.119.camel@ebony.t-mobile.de. |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Thu, 2008-07-31 at 12:32 -0400, Tom Lane wrote:
> "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> writes:
> > Martin Zaun wrote:
> >> With these avenues to be explored, can the pg_standby patch on the
> >> CommitFest wiki be moved to the "Returned with Feedback" section?
>
> > Yes, I think we can conclude that we don't want this patch as it is.
> > Instead, we want a documentation patch that describes the problem,
> > mentioning that GNU cp is safe, or you can use the copy+rename trick.
>
> Right, after which we remove the presently hacked-in delay.
>
> I've updated the commitfest page accordingly.
Well, this is a strange conclusion, leaving me slightly bemused.
The discussion between Andrew and I at PGcon concluded that we would
* document which other tools to use
* remove the delay
Now we have rejected the patch which does that, but then re-requested
the exact same thing again.
The patch interprets "remove the delay" as "remove the delay in a way
which will not screw up existing users of pg_standby when they upgrade".
Doing that requires us to have a configurable delay, which defaults to
the current behaviour, but that can be set to zero (the recommended
way). Which is what the patch implements.
Andrew, Heikki: ISTM its time to just make the changes yourselves. This
is just going round and round to no benefit. This doesn't warrant such a
long discussion and review process.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2008-08-02 10:58:26 | Parsing of pg_hba.conf and authentication inconsistencies |
Previous Message | Simon Riggs | 2008-08-02 09:41:12 | Re: Should creating a new base type require superuser status? |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2008-08-02 14:27:21 | Re: [HACKERS]odd output in restore mode |
Previous Message | Simon Riggs | 2008-08-02 09:33:37 | Re: [HACKERS] Hint Bits and Write I/O |