Re: Add PGDLLIMPORT lines to some variables

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Brian Cloutier <brian(at)citusdata(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add PGDLLIMPORT lines to some variables
Date: 2019-06-13 14:56:06
Message-ID: 12170.1560437766@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

[ blast-from-the-past department ]

Craig Ringer <craig(at)2ndquadrant(dot)com> writes:
> On 5 December 2017 at 22:49, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Mark assorted variables PGDLLIMPORT.

> I was going to pipe up here to add ReplicationSlotCtl to the list.
> Otherwise the only way to access slot information is via the SPI and
> pg_stat_replication_slots, which isn't super fun. And it's not like
> ReplicationSlotCtl is any more internal than MyReplicationSlot.

> I missed the boat on your commit, but ... please?

Not sure why this request was ignored, but now that we have another
request for the same thing [1], I've pushed this.

regards, tom lane

[1] https://postgr.es/m/345138875.20190611151943@cybertec.at

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-06-13 14:56:42 Re: ReplicationSlotCtl: undefined reference
Previous Message Alvaro Herrera 2019-06-13 14:10:43 Re: Quitting the thes