Re: Correct handling of blank/commented lines in PSQL interactive-mode history

Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> writes:
> There was one other problem mentioned in the original mail, and that
> seems to be the most serious one to me:
> [ HISTCONTROL behavior ]

The actual behavior of that option (which perhaps isn't adequately
documented) is that it suppresses a history entry if the first
character of the possibly-multi-line entry is a space. It certainly
can't operate on a per-line basis, or you'd be likely to lose chunks
of a single SQL command, so I think that definition is fine as
it is (ignoring the whole question of whether the feature is sane
at all ... but if you don't think so, why would you use it?)

Greg's patch would fix this specifically by ensuring that the line
with the space and comment is treated as a separate history entry.
So I don't really see that as a separate bug. Or, if you will,
the fact that people see it as a bug confirms that such a line
should be treated as a separate history entry.

regards, tom lane