| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: No answers on CommitFest procedures? |
| Date: | 2008-07-09 18:24:51 |
| Message-ID: | 1215627891.11418.12.camel@goldbach |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2008-07-09 at 10:58 -0700, Josh Berkus wrote:
> Have received exactly zero feedback on the question of whether I should
> be assigning reviewers to "WIP" patches or not.
I suppose it depends on what exactly "WIP" means, but I should think
that if work is still "in progress", the patch is not ready to be
reviewed yet. Patches that are truly WIP probably shouldn't be
candidates for a commit fest until they are finished, anyway.
BTW, the pg_dump lock timeout patch was previously listed as "WIP", but
I think it is better classified as "waiting for response". Waiting for a
reviewer's comments to be incorporated into a new version of the patch
should be a distinct state from waiting for the initial version of the
patch to be completed.
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2008-07-09 18:28:08 | Re: CommitFest: how does handoff work for non-committer reviewers? |
| Previous Message | Pavan Deolasee | 2008-07-09 18:11:32 | Re: No answers on CommitFest procedures? |