Re: BUG #14984: function "heap_tuple_from_minimal_tuple" lost HeapTupleHeader->t_len value

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: bucoo(at)sohu(dot)com
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #14984: function "heap_tuple_from_minimal_tuple" lost HeapTupleHeader->t_len value
Date: 2017-12-20 15:39:36
Message-ID: 12154.1513784376@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

=?utf-8?q?PG_Bug_reporting_form?= <noreply(at)postgresql(dot)org> writes:
> memset(result->t_data, 0, offsetof(HeapTupleHeaderData, t_infomask2));
> /* when memset return, result->t_data->t_len value lost
> should append code:
> HeapTupleHeaderSetDatumLength(result->t_data, len);
> */

As with #14985, you haven't shown any reason why this is a good change
to make.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2017-12-20 17:59:46 BUG #14987: pg_dump fails due to postgis linking problem
Previous Message Tom Lane 2017-12-20 15:37:35 Re: BUG #14985: ExecCopySlotTuple not set "type id" and "type mod" when from minial tuple"