Re: Fragments in tsearch2 headline

From: Sushant Sinha <sushant354(at)gmail(dot)com>
To: Pierre-Yves Strub <pierre(dot)yves(dot)strub(at)gmail(dot)com>
Cc: pgsql-general(at)postgresql(dot)org
Subject: Re: Fragments in tsearch2 headline
Date: 2008-05-23 05:10:27
Message-ID: 1211519427.8498.10.camel@dragflick
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Thanks Pierre for porting this! I just tested this for my application
and it works. There was a small bug in that startHL has to be
initialized to 0 for each chosen cover. I fixed that and attached the
new patch.

Teodor did not want a separate function. He wanted it as an extension to
ts_headline. One way to do this will be to invoke it only when options
like MaxCoverSize is used. It will be slightly ugly though.

It still seems to have bugs. I will try to clean that up.

-Sushant.

On Thu, 2008-05-22 at 13:31 +0200, Pierre-Yves Strub wrote:
> Hi,
>
> I've ported the patch of Sushant Sinha for fragmented headlines to pg8.3.1
> (http://archives.postgresql.org/pgsql-general/2007-11/msg00508.php)
>
> W.r.t, http://archives.postgresql.org/pgsql-general/2008-03/msg00806.php
> I can continue the work until this becomes an acceptable patch for pg.
>
> Pierre-yves.

Attachment Content-Type Size
headlines_v0.1.patch text/x-patch 18.9 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Alban Hertroys 2008-05-23 06:36:26 Re: quote in string
Previous Message Tino Wildenhain 2008-05-23 04:43:11 Re: Extracting \ Generate DDL for existing object permissions

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit jain 2008-05-23 06:13:12 Re: Error while executing pg_dump "invalid memory alloc request size 4294967293"
Previous Message Euler Taveira de Oliveira 2008-05-23 04:57:33 Re: BUG #4186: set lc_messages does not work