Re: pgsql: Report which WAL sync method we are trying to change *to* when it

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <mha(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Report which WAL sync method we are trying to change *to* when it
Date: 2008-05-12 19:46:12
Message-ID: 1210621572.29684.197.camel@ebony.site
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, 2008-05-12 at 15:26 -0400, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Simon Riggs wrote:
> >> Could we report both?
>
> > Yes, we could easily do that if we want to.
>
> It would be entirely silly to do so, since (a) the old value hasn't been
> changed if we fail here, and (b) it's irrelevant to the nature of the
> error.

That's reasonable. If it is impossible to set it to an
impossible/failing value then that is even better.

Magnus seems to say it is possible to set this and then have it fail
later when it is used. Not sure which is correct.

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2008-05-12 19:47:03 Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum.
Previous Message Magnus Hagander 2008-05-12 19:45:23 pgsql: Fix breakage by the wal_sync_method patch in installations that