From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andreas Seltenreich <seltenreich(at)gmx(dot)de> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: GiST index build versus NaN coordinates |
Date: | 2016-07-16 18:27:48 |
Message-ID: | 12093.1468693668@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andreas Seltenreich <seltenreich(at)gmx(dot)de> writes:
> I wrote:
>> Sounds like some fuzz testing with nan/infinity is in order.
> related fallout: close_ps returns a NULL pointer with NaNs around:
> select close_ps('(nan,nan)', '(nan,nan),(nan,nan)');
> -- TRAP: FailedAssertion("!(result != ((void *)0))", File: "geo_ops.c", Line: 2860)
Yeah, that Assert seems way too optimistic. Even without NaNs, I wonder
whether plain old roundoff error couldn't trigger cases where interpt_sl
fails to find an intersection point. I'm inclined to just let close_ps
return SQL NULL in such cases.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Jan Wieck | 2016-07-16 19:47:04 | Re: DO with a large amount of statements get stuck with high memory consumption |
Previous Message | Andres Freund | 2016-07-16 17:45:26 | Re: Reviewing freeze map code |