Re: BUG #1643: dbf2pg broken + quick fix

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Boris van Schooten" <schooten(at)cs(dot)utwente(dot)nl>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #1643: dbf2pg broken + quick fix
Date: 2005-05-03 21:15:32
Message-ID: 12065.1115154932@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

"Boris van Schooten" <schooten(at)cs(dot)utwente(dot)nl> writes:
> As it turns out, the integer checking code (contrib/dbase/dbf2pg.c, function
> isinteger) is broken. It appears the function reports 0 in case it finds a
> space in the dbf rather than a digit. I disabled it (always made it return
> 1). Now, my dbf files import fine.

Hmm. I know nothing about dbase ... but if the test has any use at all,
I guess it must be to handle NULL values. How does dbase represent a
NULL? Why is this code only checking this for integer columns?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Boris van Schooten 2005-05-03 22:32:40 Re: BUG #1643: dbf2pg broken + quick fix
Previous Message tirny 2005-05-03 18:56:59 BUG #1644: control structeres perfomance in pgsql