From: | Warren Turkal <turkal(at)google(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | timestamp datatype cleanup |
Date: | 2008-03-09 08:32:20 |
Message-ID: | 12050515403756-git-send-email-turkal@google.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
PosgreSQL hackers,
Here's an initial bit of my attempt at cleaning up the the timestamp datatype.
I have gone through the backend and made a couple small changes to stop using
the HAVE_INT64_TIMESTAMP define to select a type in code by creating typedefs
in a header and using the typedef in the code. I think this small bit is ready
for inclusion for this small bit, but I have a couple questions for further
work.
1) Is there a reason that header information is duplicated between normal
posgresql include and ecpg includes instead of defining the info in one place
and #including it into the files that need it?
2) Would it be reasonable to change timestamp.h into a file that includes other
files that define the specific parts depending on HAVE_INT64_TIMESTAMP instead
of testing for HAVE_INT64_TIMESTAMP many times throughout timestamp.h? I think
this might more cleanly separate the logic for the different timestamp types.
Thanks,
wt
From | Date | Subject | |
---|---|---|---|
Next Message | Warren Turkal | 2008-03-09 08:45:57 | timestamp datatype cleanup |
Previous Message | Oleg Bartunov | 2008-03-09 02:38:20 | Re: Google Summer of Code 2008 |