| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Takashi Horikawa <t-horikawa(at)aj(dot)jp(dot)nec(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Typo in bufmgr.c that result in waste of memory |
| Date: | 2016-02-19 13:42:08 |
| Message-ID: | 12045.1455889328@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> I see the problem, but I don't buy the argument that it wastes large
> amounts of memory. Or do you have some evidence that it does?
Agreed, it seems unlikely that that hash table gets large enough for
this to be really significant. Still ...
> I think we should fix it, but not backpatch.
I don't think that's particularly good policy. It's a clear bug, why
would we not fix it? Leaving it as-is in the back branches can have
no good effect, and what it does do is create a merge hazard for other
back-patchable bug fixes in the same area.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-02-19 13:50:09 | Re: Typo in bufmgr.c that result in waste of memory |
| Previous Message | Amit Kapila | 2016-02-19 13:33:34 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |