Re: pg_dump additional options for performance

On Tue, 2008-02-26 at 11:59 -0500, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > So if I understand:
>
> > * we add switches to pg_dump to dump out separate files with --pre,
> > --post and --data (or other names) [TODO: Simon]
>
> > * we add switches to pg_restore to load/dump from the single archive
> > file the subsets of --pre, --post, --data [TODO: Magnus]
>
> Oh dear. Apparently you do not understand that *these are the same
> switches*. The way pg_dump is structured, there is only one
> implementation to be done for both cases.

Yes, agreed. I was trying to slip away from doing it so hard I didn't
notice... that code is dog-ugly and it hurts my head, so I was looking
forward to moving onto something else :-)

I'm just testing the patch now.

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com