Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)

From: David Steele <david(at)pgmasters(dot)net>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)
Date: 2018-08-22 16:56:01
Message-ID: 11cd0aa8-d3a2-076e-4e33-d084d4e9bd6f@pgmasters.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On 8/22/18 10:56 AM, Peter Eisentraut wrote:
> On 22/08/2018 14:02, Andres Freund wrote:
>> If we agree on that, I'm going to propose a patch that includes:
>> - relevant cleanups to configure
>> - adapts sources.sgml to refer to C99 instead of C89
>> - add some trivial conversions to for(int i;;) and struct initializers,
>> so the relevant old animals fail
>> - adds a configure check to enable errors with vla usage (-Werror=vla)
>
> sounds good

Sounds good to me.

>
>> - do we want to make declarations at arbitrary points errors? It's
>> already a warning currently.
>
> While there are legitimate criticisms, it's a standard feature in C,
> C++, and many other languages, so I don't see what we'd gain by fighting it.

+1.=

--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-08-22 16:58:41 Re: Stored procedures and out parameters
Previous Message Andres Freund 2018-08-22 16:51:55 Re: Query is over 2x slower with jit=on

Browse pgsql-www by date

  From Date Subject
Next Message Andres Freund 2018-08-22 19:08:16 postgresql-archive.org
Previous Message Andres Freund 2018-08-22 15:01:47 Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)