| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com>, Srinath Reddy <srinath2133(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Non-text mode for pg_dumpall |
| Date: | 2025-04-15 18:51:48 |
| Message-ID: | 11ca924c-6c8e-4f3b-8e22-a6de50f707d5@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-04-15 Tu 2:30 PM, Mahendra Singh Thalor wrote:
> Hi Andrew,
> I did some refactoring to find out dump file extensions(.dmp/.tar etc)
> in pg_restore. With the attached patch, we will not try to find out
> file extension with each database, rather we will find out before the
> loop.
>
> Here, I am attaching a patch for the same. Please have a look over this.
That doesn't look right at first glance. You shouldn't have to tell
pg_restore what format to use, it should be able to intuit it from the
dumps (and that's what the docs say it does).
The saving here would be hardly measurable anyway - you would be in
effect saving one or two stat calls per database.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2025-04-15 18:57:32 | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Previous Message | Tom Lane | 2025-04-15 18:49:22 | Re: Fundamental scheduling bug in parallel restore of partitioned tables |