From: | Jürgen Purtz <juergen(at)purtz(dot)de> |
---|---|
To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Roger Harkavy <rogerharkavy(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Michael Paquier <michael(at)paquier(dot)xyz> |
Subject: | Re: Add A Glossary |
Date: | 2020-04-01 07:34:41 |
Message-ID: | 11c93b2a-2445-148b-30a9-35fb9eee82d7@purtz.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs pgsql-hackers |
On 31.03.20 19:58, Justin Pryzby wrote:
> On Tue, Mar 31, 2020 at 04:13:00PM +0200, Jürgen Purtz wrote:
>> Please find some minor suggestions in the attachment. They are based on
>> Corey's last patch 0001-glossary-v4.patch.
>> @@ -220,7 +220,7 @@
>> Record</glossterm>s to the file system and creates a special
>> checkpoint record. This process is initiated when predefined
>> conditions are met, such as a specified amount of time has passed, or
>> - a certain volume of records have been collected.
>> + a certain volume of records has been collected.
> I think you're correct in that "volume" is singular. But I think "collected"
> is the wrong world. I suggested "written".
>
"collected" is not optimal. I suggest "created". Please avoid "written",
the WAL records will be written when the Checkpointer is running, not
before. So:
"a certain volume of <glossterm>WAL records<glossterm> has been
collected."
Every thing else is ok for me.
Kind regards, Jürgen
From | Date | Subject | |
---|---|---|---|
Next Message | Jürgen Purtz | 2020-04-01 07:34:56 | Re: Add A Glossary |
Previous Message | Laurenz Albe | 2020-04-01 06:37:30 | Re: terminology in example |
From | Date | Subject | |
---|---|---|---|
Next Message | Jürgen Purtz | 2020-04-01 07:34:56 | Re: Add A Glossary |
Previous Message | Fujii Masao | 2020-04-01 07:22:03 | Re: recovery_target_action=pause with confusing hint |