| From: | Zeugswetter Andreas SB <ZeugswetterA(at)wien(dot)spardat(dot)at> |
|---|---|
| To: | "'tgl(at)sss(dot)pgh(dot)pa(dot)us'" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "'pgsql-hackers(at)postgresql(dot)org'" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RELEASE STOPPER? nonportable int64 constants in pg_crc.c |
| Date: | 2001-03-21 17:45:25 |
| Message-ID: | 11C1E6749A55D411A9670001FA687963368257@sdexcsrv1.f000.d0188.sd.spardat.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Recent changes in pg_crc.c (64 bit CRC) introduced non portable constants of the form:
-c -o pg_crc.o pg_crc.c
287 | 0x0000000000000000, 0x42F0E1EBA9EA3693,
............................a..................
a - 1506-207 (W) Integer constant 0x42F0E1EBA9EA3693 out of range.
I guess this will show up on a lot of non gcc platforms !!!!!
It shows no diffs in the regression tests! From what I understand,
failure would only show up after fast shutdown/crash.
Attached is a patch, but I have no idea how portable that is.
Andreas
| Attachment | Content-Type | Size |
|---|---|---|
| pg_crc.patch | application/octet-stream | 11.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-03-21 17:49:35 | Chat starts in 10 minutes |
| Previous Message | Marek PUBLICEWICZ | 2001-03-21 17:35:03 | Strange results of CURRENT_TIMESTAMP |