From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Subject: | [Fwd: Re: [HACKERS] Postgres 8.3 archive_command] |
Date: | 2007-11-22 09:32:51 |
Message-ID: | 1195723971.4246.128.camel@ebony.site |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Small patch to reduce archive messages to DEBUG1 attached.
-------- Forwarded Message --------
From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Rudolf van der Leeden
<vanderleeden(at)logicunited(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Postgres 8.3 archive_command
Date: Wed, 21 Nov 2007 18:27:46 +0000
On Wed, 2007-11-21 at 12:24 -0500, Tom Lane wrote:
> "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> > Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Just to clarify: I don't object to lowering "successfully archived"
> >> messages to DEBUG1, if the field consensus is that it's too chatty.
> >> What I didn't like was the idea of logging some events but not other
> >> identical events.
>
> > Agreed on the intermittent logging. I don't feel it's too chatty,
> > but on the other hand, I could always change the logging level on
> > the fly if I was investigating a problem, so it wouldn't be much of
> > an inconvenience to switch it if it bugs others.
>
> Also, you can always tweak your archive_command script to do some
> logging of its own, so it's always possible to make the thing more
> noisy if you need to. Less noisy, though, is hard without changing
> the server code.
OK, both of those thoughts are good, so happy now with DEBUG1 for
success messages: "archived transaction log file..."
Enclosed patch to set archived message to DEBUG1.
I've got a few other comments for PITR docs, so I'll mention this also
in forthcoming patch.
--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com
Attachment | Content-Type | Size |
---|---|---|
archive_success_debug1.v1.patch | text/x-patch | 663 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Marko Kreen | 2007-11-22 12:16:26 | plpython crash on exception |
Previous Message | Bruce Momjian | 2007-11-21 23:13:02 | Re: [BUGS] BUG #3770: Follow up: Fail to make bcc32.mak for libpq |