| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: GIN needs tonic |
| Date: | 2009-09-15 14:48:01 |
| Message-ID: | 11951.1253026081@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> This means that the WAL replay of that record type has never been tested
> correctly :-(. Looking closer at writeListPage(), why does it always
> include 'workspace' in the WAL record, even if a full-page-image is
> taken? It's not used for anything the the redo function. That's
> harmless, but bloats the WAL record unnecessary. In fact it might be
> better to never do full-page writes for that record type, since it
> completely overwrites the page anyway.
Actually, the entire thing is misdesigned from the get-go. AFAICS
it shouldn't even have its own WAL record type --- it should be using
log_newpage().
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2009-09-15 15:47:18 | Re: error: message type 0x5a arrived from server while idle |
| Previous Message | Sam Mason | 2009-09-15 14:19:42 | Re: [BUGS] BUG #5053: domain constraints still leak |