Re: Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter
Date: 2007-09-18 23:25:36
Message-ID: 11947.1190157936@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> We can revert that if necessary. It will open up a hole, though. Take
> your pick - spec compliance or validly coded data.

I would rather take CONVERT USING out altogether, than have an
implementation that so clearly disregards the spec as to not even return
a compatible datatype.

Other than the fact that it's supposed to return varchar, the spec's
description of what it converts to what seems about as clear as mud.
I suspect however that it can't really be implemented properly without
support for per-value (or at least per-column) encoding, which is
something we're nowhere near having. Maybe we *should* take it out
instead of using spec-defined syntax for a behavior that we made up
out of whole cloth.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2007-09-19 00:09:00 Re: Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter
Previous Message Andrew Dunstan 2007-09-18 23:08:55 Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2007-09-19 00:09:00 Re: Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter
Previous Message Andrew Dunstan 2007-09-18 23:23:52 Re: pg_ctl -w vs unix_socket_directory