Re: Autovacuum cancellation

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Autovacuum cancellation
Date: 2007-10-28 08:46:32
Message-ID: 1193561192.4242.649.camel@ebony.site
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

On Sat, 2007-10-27 at 23:22 +0100, Simon Riggs wrote:
> On Fri, 2007-10-26 at 10:32 +0100, Heikki Linnakangas wrote:
> > Alvaro Herrera wrote:
> > > /*
> > > * Look for a blocking autovacuum. There will only ever
> > > * be one, since the autovacuum workers are careful
> > > * not to operate concurrently on the same table.
> > > */
> >
> > I think that's a bit unaccurate. You could have multiple autovacuum
> > workers operating on different tables participating in a deadlock. The
> > reason that can't happen is that autovacuum never holds a lock while
> > waiting for another.
>
> I wrote that code comment; as you say it is true only when there are at
> least 4 processes in the lock graph where 2+ normal backends are
> deadlocking and there are 2+ autovacuums holding existing locks. The
> comment should have said "If blocking is caused by an autovacuum process
> then ... (there will)".

Sorry...this should read "as you say it is **not** true".

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2007-10-28 09:06:51 Re: pgsql: Allow an autovacuum worker to be interrupted automatically when
Previous Message Alvaro Herrera 2007-10-28 01:13:19 Re: pgsql: Allow an autovacuum worker to be interrupted automatically when

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2007-10-28 09:06:51 Re: pgsql: Allow an autovacuum worker to be interrupted automatically when
Previous Message Sebastien FLAESCH 2007-10-28 07:45:16 Re: PostgreSQL 8.3, libpq and WHERE CURRENT OF

Browse pgsql-patches by date

  From Date Subject
Next Message Gokulakannan Somasundaram 2007-10-28 10:27:57 Re: [PATCHES] Including Snapshot Info with Indexes
Previous Message Simon Riggs 2007-10-27 22:31:02 Re: Autovacuum cancellation