Sigh, I broke crake again

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Sigh, I broke crake again
Date: 2018-02-27 18:36:59
Message-ID: 11927.1519756619@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I just committed some regression test cleanup that removed or renamed
a couple of C-language functions in regress.so. I see that crake is
now failing XversionUpgrade tests, and although I can't see the details,
I bet the problem is from trying to load CREATE FUNCTION commands from
the old regression databases that now don't point to an existing C
function.

Does it seem practical to adjust TestUpgradeXversion.pm to cope with
this change? An alternative answer is to put back C-language stubs
in regress.c for the removed functions, but that seems a bit grotty.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-02-27 18:40:14 Re: [HACKERS] Partition-wise aggregation/grouping
Previous Message Pavan Deolasee 2018-02-27 18:19:11 Re: [HACKERS] MERGE SQL Statement for PG11