Re: Proposed patch for bug #3921

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Proposed patch for bug #3921
Date: 2008-02-03 16:02:40
Message-ID: 11927.1202054560@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> So the syntax would be

> CREATE TABLE foo (..., LIKE bar INCLUDING INDEXES USING INDEX TABLESPACE foo_ts, ...)

This (presumably) forces all the indexes into the same tablespace,
so I don't find it to be a complete solution, just a wart.

We could get the same behavior with much less code if we redefined
LIKE to not try to copy the source indexes' tablespace(s). Then,
the user would set default_tablespace to get the effect of the
USING clause.

That would also make LIKE entirely free of tablespace permissions
hazards, so I'm starting to think more and more that that's really the
right definition.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Greg Sabino Mullane 2008-02-03 18:52:33 Re: Better default_statistics_target
Previous Message Gregory Stark 2008-02-03 13:39:53 Re: Proposed patch for bug #3921