Re: quote_literal with NULL

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: quote_literal with NULL
Date: 2007-10-10 15:55:20
Message-ID: 1192031720.4233.263.camel@ebony.site
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Wed, 2007-10-10 at 10:12 -0500, Kevin Grittner wrote:
> >>> On Wed, Oct 10, 2007 at 4:57 AM, in message
> <37ed240d0710100257r149a8d2cmb671b69a1673eb54(at)mail(dot)gmail(dot)com>, "Brendan Jurd"
> <direvus(at)gmail(dot)com> wrote:
> > On 10/10/07, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> >> On Wed, 2007-10-10 at 14:57 +1000, Brendan Jurd wrote:
> >>
> >> > Wouldn't it be more useful if quote_literal(NULL) yielded the text value
> > 'NULL'?
> >>
> >> I don't think you can change that now. There could be code out there
> >> that relies on that behaviour.
> >>
> >
> > Bummer. But I take your point. If there's a good chance someone is
> > going to have their application murdered by a change here, best to
> > leave it alone.
>
> In particular, it seems like exactly what you would want for values
> you're going to use in an INSERT or the SET clause of an UPDATE.

Perhaps have quote_nullable() then as well?

You then use quote_nullable() in INSERT and UPDATE SET clauses and
quote_literal() in SELECT WHERE clauses.

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Trevor Talbot 2007-10-10 15:56:17 Re: Timezone database changes
Previous Message Simon Riggs 2007-10-10 15:50:53 Re: Skytools committed without hackers discussion/review

Browse pgsql-patches by date

  From Date Subject
Next Message Greg Sabino Mullane 2007-10-10 16:24:59 Re: quote_literal with NULL
Previous Message Kevin Grittner 2007-10-10 15:12:31 Re: quote_literal with NULL