Re: Skytools committed without hackers discussion/review

On Tue, 2007-10-09 at 16:50 -0700, Joshua D. Drake wrote:
> I think this almost says it all. My particular gripe about this whole
> thing is that there are other features that are not too intrusive (or
> appear so anyway) that are easily more useful that are not being
> considered at all. Namely,
> http://archives.postgresql.org/pgsql-patches/2007-10/msg00087.php .

That is NOT a good example. That patch is a first-cut of a non-trivial
optimizer feature that was submitted just before beta1 shipped, by
someone who hasn't modified the optimizer before. Jan's patch was a
contrib module that has been already developed by the Skype folks, and
it goes without saying that Jan has contributed to Postgres extensively.

> It makes the whole process seem tilted and subjective.

There are some fairly obvious, objective reasons why txid differs from
the inline-SQL-SRF patch.

That said, I agree that the process should have been followed in this
case.

-Neil