Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Denis Perchine <dyp(at)perchine(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS
Date: 2001-01-21 07:08:07
Message-ID: 11915.980060887@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Denis Perchine <dyp(at)perchine(dot)com> writes:
> First of all it will not break lo_creat, lo_unlink for sure.

lo_creat depends on inv_create followed by inv_close; your patch
proposed to disable both of those outside transaction blocks.
lo_unlink depends on inv_drop, which ditto. Your patch therefore
restricts lo_creat and lo_unlink to be done inside transaction blocks,
which is a new and completely unnecessary restriction that will
doubtless break many existing applications.

> But I do not see any reasons why we not put lo_import, and lo_export in TX.
> At least this will prevent other backends from reading partially imported
> BLOBs...

lo_import and lo_export always execute in a transaction, just like any
other backend operation. There is no need to force them to be done in
a transaction block. If you're not clear about this, perhaps you need
to review the difference between transactions and transaction blocks.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Denis Perchine 2001-01-21 07:09:46 Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS
Previous Message Denis Perchine 2001-01-21 06:48:17 Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS

Browse pgsql-patches by date

  From Date Subject
Next Message Denis Perchine 2001-01-21 07:09:46 Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS
Previous Message Denis Perchine 2001-01-21 06:48:17 Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS