Re: query_id: jumble names of temp tables for better pg_stat_statement UX

Sami Imseih <samimseih(at)gmail(dot)com> writes:
> For example, I have seen users add comments to SQLs to differentiate
> similar SQLs coming from different tenants. This patch makes this no longer a
> somewhat decent workaround to overcome the fact that pg_stat_statements
> does not track schemas or search path.

Well, the workaround is different, but that doesn't mean there is no
workaround. You just need to alter a table alias in the query:

select * from foo s1;
select * from foo s2;

As against this, there is probably also a set of people who would
*like* identical queries on identically-rowtyped tables in different
schemas to be merged. Right now they have no way to make that happen.

So yeah, it's a nontrivial behavioral change. But I think on the
whole it's likely to be more useful. We could always revert the
change during beta if we get too much pushback.

regards, tom lane