| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reasons not to like asprintf |
| Date: | 2013-10-25 02:07:28 |
| Message-ID: | 11875.1382666848@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Oct 24, 2013 at 2:18 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> While this is attractive, the same logic would suggest that we rename
>> pg_malloc() to palloc(), and that sounds wrong. The frontend and
>> backend functions do have different freeing semantics.
> I'd almost be inclined to go the other way and suggest that we try to
> use the pg_ prefix more, at least for things to be shared between
> front and back end code.
Meh. I think that mainly promotes carpal tunnel syndrome. The place
for a pg_ prefix is in functions we intend to expose to the "outside
world", such as functions exposed by libpq. But these are not that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sawada Masahiko | 2013-10-25 02:14:18 | Re: Patch for fail-back without fresh backup |
| Previous Message | Josh Berkus | 2013-10-25 00:17:22 | Re: CLUSTER FREEZE |