From: | "Simon Riggs" <simon(at)2ndquadrant(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "George Wilk" <gwilk(at)ellacoya(dot)com>, <pgsql-admin(at)postgresql(dot)org> |
Subject: | Re: missing history file |
Date: | 2007-07-02 09:35:56 |
Message-ID: | 1183368957.3589.160.camel@silverbirch.site |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-admin |
On Fri, 2007-06-29 at 10:52 -0400, Tom Lane wrote:
> "Simon Riggs" <simon(at)2ndquadrant(dot)com> writes:
> > Just ignore 00000001. Recovery will work fine even if absent. Don't
> > ignore all history files though, just that one. Hmmm, come to think of
> > it, why is it requesting it at all? We should just skip that request.
>
> No, because then people would misdesign their recovery scripts to not
> be able to deal with not finding a history file. As things are, they
> will certainly be exposed to that case in any testing they do. If we
> optimize this call away, then they won't see the case until they're in
> very deep doo-doo.
Main reason for suggesting this is that there is already code to
optimize the call away in one place, but not in another, which seems
strange either way.
--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Yuan HOng | 2007-07-02 12:41:10 | |
Previous Message | Joe Barwell | 2007-07-02 01:23:31 | Re: initdb problem |