| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <akapila(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Implement streaming mode in ReorderBuffer. |
| Date: | 2020-09-09 22:47:16 |
| Message-ID: | 118303.1599691636@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Amit Kapila <akapila(at)postgresql(dot)org> writes:
> Implement streaming mode in ReorderBuffer.
Looks like this test is somewhat unstable still:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2020-09-09%2003%3A42%3A19
diff -U3 /home/andres/build/buildfarm/HEAD/pgsql.build/../pgsql/contrib/test_decoding/expected/stream.out /home/andres/build/buildfarm/HEAD/pgsql.build/contrib/test_decoding/results/stream.out
--- /home/andres/build/buildfarm/HEAD/pgsql.build/../pgsql/contrib/test_decoding/expected/stream.out 2020-08-08 09:18:34.493194657 +0000
+++ /home/andres/build/buildfarm/HEAD/pgsql.build/contrib/test_decoding/results/stream.out 2020-09-09 04:19:12.985912853 +0000
@@ -71,6 +71,8 @@
data
------------------------------------------
opening a streamed block for transaction
+ closing a streamed block for transaction
+ opening a streamed block for transaction
streaming change for transaction
streaming change for transaction
streaming change for transaction
@@ -83,7 +85,7 @@
streaming change for transaction
closing a streamed block for transaction
committing streamed transaction
-(13 rows)
+(15 rows)
It's likely relevant that skink uses valgrind, which'd slow it
down a lot. That suggests some timing dependency is still there.
(Note that skink has passed this test multiple times.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2020-09-10 01:52:57 | pgsql: Fix rd_firstRelfilenodeSubid for nailed relations, in parallel w |
| Previous Message | Tom Lane | 2020-09-09 19:33:02 | pgsql: Make archiver's SIGQUIT handler exit via _exit(). |