From: | Ronan Dunklau <ronan(at)dunklau(dot)fr> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Preserve attstattarget on REINDEX CONCURRENTLY |
Date: | 2021-02-05 07:22:17 |
Message-ID: | 11797662.T7Z3S40VBb@laptop-ronand |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Le vendredi 5 février 2021, 03:17:48 CET Michael Paquier a écrit :
> ConstructTupleDescriptor() does not matter much, but this patch is not
> acceptable to me as it touches the area of the index creation while
> statistics on an index expression can only be changed with a special
> flavor of ALTER INDEX with column numbers. This would imply an ABI
> breakage, so it cannot be backpatched as-is.
I'm not surprised by this answer, the good news is it's being back-patched.
>
> Let's copy this data in index_concurrently_swap() instead. The
> attached patch does that, and adds a test cheaper than what was
> proposed. There is a minor release planned for next week, so I may be
> better to wait after that so as we have enough time to agree on a
> solution.
Looks good to me ! Thank you.
--
Ronan Dunklau
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2021-02-05 07:43:44 | Re: Preserve attstattarget on REINDEX CONCURRENTLY |
Previous Message | osumi.takamichi@fujitsu.com | 2021-02-05 07:06:15 | RE: Single transaction in the tablesync worker? |