| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Ankit Kumar Pandey <itsankitkp(at)gmail(dot)com> |
| Cc: | pghackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Distinct tightly coupled with Agg |
| Date: | 2022-11-15 18:56:05 |
| Message-ID: | 1178736.1668538565@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Ankit Kumar Pandey <itsankitkp(at)gmail(dot)com> writes:
> I am looking at todo item (#1) /Implement DISTINCT clause in window
> aggregates/ and while looking at code, I found distinct tightly coupled
> with Agg function. Looking at another todo item(#2) /Do we really need
> so much duplicated code between Agg and WindowAgg/? I was wondering
> what is general stance on this? Is #2 per-requisite for #1?
No, I think #2 is just a general statement of annoyance. It'd be
great if someone finds a way to refactor things to improve that; but
seeing that window functions operate in a much different environment
than plain aggregates, I'm not holding my breath. It's certainly
not a prerequisite for any other work in the area.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-11-15 19:04:25 | Re: meson oddities |
| Previous Message | Ankit Kumar Pandey | 2022-11-15 18:50:06 | Re: Distinct tightly coupled with Agg |