| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Ranier Vilela <ranier_gyn(at)hotmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Proposal] Level4 Warnings show many shadow vars |
| Date: | 2019-12-09 15:23:08 |
| Message-ID: | 11755.1575904988@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sun, Dec 8, 2019 at 1:52 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I don't think I'm actually on board with the goal here.
> I don't know what to do about the RedoRecPtr mess, but surely
> subscriptioncmds.c's use of synchronous_commit as a char * when it's
> already exists as a global variable of type int is not good practice.
Well, again, this is a case-by-case question. I tend to agree that
changing that usage in subscriptioncmds.c might be a good idea.
That doesn't mean I need to be on board with wholesale removal
of shadowing warnings.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Delplanque | 2019-12-09 15:35:01 | Questions about PostgreSQL implementation details |
| Previous Message | Robert Haas | 2019-12-09 14:35:30 | Re: ERROR: uncommitted xmin 347341220 from before xid cutoff 967029200 needs to be frozen |