| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Gevik Babakhani <pgdev(at)xs4all(dot)nl> |
| Cc: | pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: guid/uuid datatype |
| Date: | 2007-01-20 00:18:08 |
| Message-ID: | 1169252288.27197.25.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Sat, 2007-01-20 at 00:21 +0100, Gevik Babakhani wrote:
> AFAIK, It is/was part of the TODO for the core.
Well, I don't have a strong opinion either way, but I think it should be
given some thought.
As far as the code, looks pretty good. A few minor comments:
* varchar_uuid() should be named uuid_varchar(), for consistency with
the other function names. In fact, uuid_text() and varchar_uuid() are
essentially identical, so they should be refactored. The fmgr interface
macros can stay, I guess.
* most of uuid.h can be gotten rid of: the SQL-callable functions are
already declared in builtins.h, and most of the other declarations
should be moved to uuid.c and made local to that file.
* needs documentation
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-01-20 00:19:15 | Re: guid/uuid datatype |
| Previous Message | Albert Cervera Areny | 2007-01-19 23:23:12 | Re: [PATCHES] Tablespace for temporary objects and |