Re: [PATCHES] [Fwd: Index Advisor]

On Mon, 2007-01-08 at 12:16 -0500, Tom Lane wrote:
> "Simon Riggs" <simon(at)2ndquadrant(dot)com> writes:
> > On Mon, 2007-01-08 at 11:28 -0500, Bruce Momjian wrote:
> >> The complex part of this is that the feature requires patches to the
> >> backend, and has a /contrib component.
>
> > The plugin approach is exactly what happened with the debugger. The
> > backend has an appropriate plugin API and the debugger is a plugin.
>
> > The patch to the backend shouldn't be in contrib, definitely.
>
> > I would say its up to the installer to offer the opportunity to load the
> > adviser plugin, or not. I like plugins because they encourage faster
> > paced development, diversity and choice.
>
> I would suggest that if we want to encourage faster development, we
> should do the same thing we did with the plpgsql debugger support:
> put the plugin hooks into the backend and keep the actual plugin(s)
> as separate pgfoundry projects. That way the index advisor can have
> a release every few weeks if it needs it .... and it will, for awhile.
> Stuff in contrib is necessarily tied to the backend release cycle.
>
> (This is not a statement that I approve of the specific plugin hooks
> proposed --- I don't particularly. But if we can come up with something
> a bit cleaner, that's how I'd approach it.)

Sounds good to me.

--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com