Re: Constifying numeric.c's local vars

Andres Freund <andres(at)anarazel(dot)de> writes:
> One large user of unnecessary non-constant static variables is
> numeric.c. More out of curiosity - numeric is slow enough in itself to
> make inlining not a huge win - I converted it to use consts.

LGTM.

> It's a bit ugly that some consts have to be casted away in the constant
> definitions, but aside from just inlining the values, I don't quite see
> a better solution?

No, I don't either. I'm not sure that writing the constant inline would
produce the desired results - the compiler might well decide that it had
to be in read-write storage.

regards, tom lane