Re: vacuum_truncate configuration parameter and isset_offset

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Treat <rob(at)xzilla(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Albe <laurenz(dot)albe(at)cybertec(dot)at>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Will Storey <will(at)summercat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: vacuum_truncate configuration parameter and isset_offset
Date: 2025-03-25 16:35:23
Message-ID: 11628190.0AQdONaE2F@thinkpad-pgpro
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

В письме от вторник, 25 марта 2025 г. 17:57:46 MSK пользователь Nathan Bossart
написал:

> In any case, AFAICT the votes are somewhat evenly divided at the moment, so
> I do not intend to proceed with this patch for now.

Counting votes does not lead anywhere, as I can ask friends and colleagues to
vote for me for example. This is wrong way.

There are people who involved it supporting reloption engine. If Alvaro said
"isset_offset" is good, let's have it, I will shut keep my mouth shut, right
after saying "As you say". Because he is the author of that part of the code,
I respect this.

I am also the person that dedicated lot's of efforts to work with reloptions. I
will do it for may years ahead, I think. This isset_offset I will have to
support from now on, if we do not revert it. I do not like it, I see there is
no logic in it, at least the way you suggest it.

If you want to dedicate part of your life to reloptions, you are welcome. I
need help with a code to review. If you really need isset_offset let's together
redisign options to use it instead of default_value. Go for it, but not
partly, but totally.

But if you want to fix one option and leave, please do not leave us with
isset_offset.

This is not about democracy, this is about who will deal with that part of the
code later. I guess it will be me and Alvaro, not you. Please let us have the
code the way we like it, since we support it most of the time.

--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-03-25 16:46:51 Re: Add missing PQclear for StreamLogicalLog function
Previous Message Christoph Berg 2025-03-25 16:28:59 Squash constant lists in query jumbling by default