Re: [HACKERS] Forcing current WAL file to be archived

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, Hannu Krosing <hannu(at)skype(dot)net>
Subject: Re: [HACKERS] Forcing current WAL file to be archived
Date: 2006-08-16 06:05:47
Message-ID: 1155708347.2649.185.camel@holly
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Tue, 2006-08-15 at 18:42 -0400, Tom Lane wrote:
> I wrote:
> > It'd definitely be nicer that way, but given the current limitations of
> > bootstrap mode I see no non-kluge way to make a built-in function have
> > OUT parameters. (Hint: array_in doesn't work in bootstrap mode.)
>
> Actually, that turns out not to be so hard to fix as I thought.
> array_in only needs to work for the array types used in the core system
> tables, and bootstrap.c already has a hard-wired table of that info ...
> we only have to make it available to array_in. Which I just did.

Cool; I'd noticed that this would have been the first such function.

> So let's fix pg_xlogfile_name_offset() to have two OUT parameters
> instead of returning a smushed-together string.

I'll do this, but I'm conscious that this is a cosmetic change.

I'm going on vacation very soon now, so test reports of the major
functionality would be greatly appreciated.

--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jie Zhang 2006-08-16 07:03:26 Re: [PATCHES] WIP: bitmap indexes
Previous Message Josh Berkus 2006-08-16 05:43:12 Re: BugTracker (Was: Re: 8.2 features status)

Browse pgsql-patches by date

  From Date Subject
Next Message Jie Zhang 2006-08-16 07:03:26 Re: [PATCHES] WIP: bitmap indexes
Previous Message Tatsuo Ishii 2006-08-16 02:26:43 Re: pgbench: handring empty lines in external scripts