Re: newbie patch-attempt: selecting large result sets in

From: Neil Conway <neilc(at)samurai(dot)com>
To: Chris Mair <list(at)1006(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: newbie patch-attempt: selecting large result sets in
Date: 2006-07-12 05:18:09
Message-ID: 1152681490.5374.8.camel@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 2006-07-11 at 21:19 +0200, Chris Mair wrote:
> One of the problems with this was that a user would expect psql to
> work as usual (including all format and output option stuff) and
> to do this properly most of the psql output code would need to be
> refactored.

Even if the refactoring were done, I think having a separate interface
would be a good idea, because it makes it more obvious that queries
submitted via cursors behave differently (e.g. in the case of a network
failure in the midst of executing the query).

> The patch is here [2], is working, but needs some performance
> improvment and double checking.

BTW, the patch leaks the content of "buf" (you need to
termPQExpBuffer()).

-Neil

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2006-07-12 05:26:19 Re: Three weeks left until feature freeze
Previous Message ITAGAKI Takahiro 2006-07-12 04:57:15 Re: passing parameters to CREATE INDEX