Re: plpgsql raise - parameters can be expressions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Pavel Stehule <stehule(at)kix(dot)fsv(dot)cvut(dot)cz>, pgsql-patches(at)postgresql(dot)org
Subject: Re: plpgsql raise - parameters can be expressions
Date: 2005-06-14 01:01:00
Message-ID: 11519.1118710860@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> Tom Lane wrote:
>> Actually, the reason I didn't do something about RAISE in 8.0 was that
>> I thought we should reconsider the whole design of the statement

> The ensuing discussion on this sounds good to me; should I apply Pavel's
> RAISE patch now, or wait for the subsequent work on specifying a
> particular SQLSTATE?

The patch seems to me to be OK as far as it goes. I brought up the
other points only because I wanted to be sure that it wouldn't be
inconsistent with the next step; but it seems we're pretty well agreed
that we aren't going to do anything that would break this. So I have no
problem with applying as-is, rather than waiting for an all-inclusive
patch.

But you had mentioned wanting to look at reducing overhead by using
exec_eval_expr(); were you intending to do that before committing?

As far as the subsequent discussion itself goes, Pavel and I seem to
be pretty unsuccessful at convincing each other of our respective
visions of what an exception ought to be. Any opinions? Should
we be taking this thread to -hackers for a wider audience?

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-06-14 03:04:28 Re: logfile for psql patch update
Previous Message Neil Conway 2005-06-14 00:45:46 Re: plpgsql raise - parameters can be expressions