| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Zeugswetter Andreas SB <ZeugswetterA(at)wien(dot)spardat(dot)at> |
| Cc: | "'Peter Eisentraut'" <peter_e(at)gmx(dot)net>, Philip Warner <pjw(at)rhyme(dot)com(dot)au>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: AW: More on elog and error codes |
| Date: | 2001-03-20 17:29:38 |
| Message-ID: | 11498.985109378@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Zeugswetter Andreas SB <ZeugswetterA(at)wien(dot)spardat(dot)at> writes:
> PGELOG(ERROR, PGSQLSTATE_TYPE, ("type %s cannot be created because it already exists", ...))
> put varargs into parentheses to avoid need for ... macros see Tom's proposal
I'd be inclined to make it
PGELOG((ERROR, PGSQLSTATE_TYPE, "type %s cannot be created because it already exists", ...))
The extra parens are ugly and annoying in any case, but they seem
slightly less so if you just double the parens associated with the
PGELOG call. Takes less thought than adding a paren somewhere in the
middle of the call. IMHO anyway...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | The Hermit Hacker | 2001-03-20 18:11:18 | Final Call: RC1 about to go out the door ... |
| Previous Message | Larry Rosenman | 2001-03-20 16:57:38 | Re: AW: Re: More on elog and error codes |