Re: That EXPLAIN ANALYZE patch still needs work

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Martijn van Oosterhout <kleptog(at)svana(dot)org>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: That EXPLAIN ANALYZE patch still needs work
Date: 2006-06-07 20:44:50
Message-ID: 1149713090.2680.45.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2006-06-07 at 15:32 -0400, Tom Lane wrote:
> Ah-hah, I've sussed it.

> so I'm
> afraid this approach to sampling EXPLAIN ANALYZE is a failure.

Hmmm, I thought we already got that bit...sorry to sound negative.

> I propose we revert this patch and think about an interrupt-driven
> sampling method instead.

I don't have much more faith in crazy scheme No.2 either. (Mine or
yours...)

Can we just have an option to avoid the timing altogether, please? I
don't want to have long discussions about instrumentation, I just want a
reasonably useful EXPLAIN ANALYZE in a reasonable amount of time - one
that we never, ever have to doubt whether the sampling works correctly
on a Miasmic-367 with HyperKooling. You could lose a month on -perform
going into the details of this for everybody - this was supposed to be a
simple additional feature.

If you're set on the sampling, great, but can we have the option to
avoid it completely also?

--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-06-07 20:56:27 Re: That EXPLAIN ANALYZE patch still needs work
Previous Message Jim C. Nasby 2006-06-07 20:38:33 Re: How to avoid transaction ID wrap