Re: tap tests remove working directories

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tap tests remove working directories
Date: 2015-08-07 21:11:27
Message-ID: 11453.1438981887@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> One of the things that makes the TAP tests very difficult and annoying
> to debug is their insistence on removing their data directories. I'm not
> sure why they are doing that. We don't do that with pg_regress. Instead
> we have clean targets to remove them if necessary. I suggest that we
> either disable that altogether, and provide cleanup make targets, or at
> least make it optional, say by setting an environment variable, say
> TMP_CLEANUP or some such. There is probably a good case for defaulting
> that to off, but I could live with it being on.

I thought we'd decided awhile ago that best practice would be to
auto-remove temp directories only on success. Is that a workable
behavior for you, or are you concerned about being able to poke
around even after the test thinks it succeeded?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gavin Flower 2015-08-07 21:23:04 Re: 9.5 release notes
Previous Message Andrew Dunstan 2015-08-07 21:01:23 tap tests remove working directories