| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add psql option: -1 or --single-transaction |
| Date: | 2006-02-14 14:49:34 |
| Message-ID: | 1139928574.1258.936.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, 2006-02-14 at 09:35 -0500, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > On Tue, 2006-02-14 at 16:55 +0800, Christopher Kings-Lynne wrote:
> >> Huh? But it'll cause a total failure of dump restore?
>
> > Perhaps you can explain further?
>
> As the code stands, a restore involving blobs plus --single-transaction
> produces
> BEGIN;
> ...
> BEGIN;
> ...
> COMMIT;
> ...
> COMMIT;
> which does *not* have the intended behavior because BEGIN does not nest.
> This is a must-fix, else we may as well revert the patch entirely,
> because it does not work.
How should it work?
1. Remove the BEGIN and COMMIT around blobs?
2. Use SAVEPOINT ?
Presumably (1).
Best Regards, Simon Riggs
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-02-14 14:57:02 | Re: pgsql: Add psql option: -1 or --single-transaction |
| Previous Message | Tom Lane | 2006-02-14 14:35:13 | Re: pgsql: Add psql option: -1 or --single-transaction |