Re: Request for Comments: ALTER [OBJECT] SET SCHEMA

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bernd Helmle <mailings(at)oopsware(dot)de>
Cc: PostgreSQL-Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Request for Comments: ALTER [OBJECT] SET SCHEMA
Date: 2005-06-09 14:17:33
Message-ID: 11388.1118326653@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bernd Helmle <mailings(at)oopsware(dot)de> writes:
> --On Mittwoch, Juni 08, 2005 14:49:56 -0400 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> wrote:
>> Applying "const" to pointers that point to things that are not const,
>> as in
>>
>> + void
>> + ApplyTypeNamespace( Oid typeOid,
>> + const Relation rel,
>>
>> seems to me to be horrible style, even if the compiler lets you do it.
>> It's too easy to misread it as a promise not to alter the pointed-to
>> object.

> Well, i thought there *should* be a promise, not to alter *rel in that
> specific case.

Hmm? You're planning to write into the relation in question. It's
hardly likely that the structure can be expected to remain virgin...
in practice I don't think we guarantee that even for read operations.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-06-09 14:49:34 Re: [HACKERS] Strange transaction-id behaviour? (was Re: Two updates problem)
Previous Message Bruce Momjian 2005-06-09 14:06:34 Re: autovacuum in backend?