| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Josh Berkus <josh(at)agliodbs(dot)com> |
| Subject: | Re: machine-readable explain output |
| Date: | 2009-06-14 15:28:44 |
| Message-ID: | 11384.1244993324@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sat, Jun 13, 2009 at 6:40 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I believe we have things set up so that you can still print "xml" data
>> without libxml configured in. We'd need to be sure casting to text
>> works too, but other than that I don't see an issue here.
> Hmm, I just tried to do this by modifying ExplainResultDesc to use
> XMLOID rather than TEXTOID when stmt->format == EXPLAIN_FORMAT_XML,
> and sure enough, explain (format xml) ... fails when --with-libxml is
> not specified.
That's because the code goes through BuildTupleFromCStrings, which
invokes xml_in in this scenario, and xml_in (as opposed to xml_out)
does depend on libxml.
However, using BuildTupleFromCStrings is wasteful/stupid for *both*
text and xml output, so it seems like getting rid of it is the thing
to do here.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2009-06-14 15:59:58 | Re: [GENERAL] Using results from DELETE ... RETURNING |
| Previous Message | Tom Lane | 2009-06-14 15:21:18 | Re: machine-readable explain output |