Re: leaks in TopMemoryContext?

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: leaks in TopMemoryContext?
Date: 2006-01-11 08:06:07
Message-ID: 1136966767.9143.78.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2006-01-11 at 02:58 -0500, Tom Lane wrote:
> One comment is that there are worse things than small memory leaks in
> seldom-followed code paths, especially if those paths are only taken in
> error cases.

While I agree the problem isn't a showstopper, I think it is still
worthy of concern: the mbutils example was chosen for being clearly
broken, not as being the most serious instance of the problem. The issue
might occur in *any* situation in which we're allocating memory in a
memory context whose lifetime exceeds the current transaction -- I
haven't looked to see what other places might need fixing.

-Neil

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message ITAGAKI Takahiro 2006-01-11 10:32:43 Overflow of bgwriter's request queue
Previous Message Tom Lane 2006-01-11 07:58:32 Re: leaks in TopMemoryContext?