Re: Using multi-row technique with COPY

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Using multi-row technique with COPY
Date: 2005-11-29 20:42:49
Message-ID: 1133296969.2906.400.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 2005-11-29 at 14:56 -0500, Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> Something that would probably be reasonable, and require *no* weird new
> >> syntax, is to shortcut in a COPY into a table created in the current
> >> transaction. I believe we still keep a flag in the relcache indicating
> >> whether that's the case ...
>
> > So if the table is created in the current transaction, we don't log?
>
> Log, yes, unless it's a temp table. The point is we could avoid taking
> buffer content locks. Come to think of it, we could implement that
> trivially in the heapam.c routines; it would then apply to any table
> update whether generated by COPY or otherwise.

We should do that, yes, we've discussed that before. I'm happy to blat
that out.

...but I do still want to improve COPY in other ways.

> > Yes, I guess, but do we want to propogate that into pg_dump output? I
> > would think not.
>
> Exactly my point; we don't have to change any syntax, so pg_dump
> doesn't care.

Does pg_dump wrap the CREATE TABLE and COPY into the same transaction?

Best Regards, Simon Riggs

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-11-29 20:58:22 Re: Using multi-row technique with COPY
Previous Message Simon Riggs 2005-11-29 20:35:25 Re: Using multi-row technique with COPY