Re: Latest ecpg patch broke MSVC build

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Latest ecpg patch broke MSVC build
Date: 2007-10-01 03:46:00
Message-ID: 11319.1191210360@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> It is building with thread.c but it should not be unless I am misreading
> the Makefile. The makefile processing in Project.pm doesn't look nearly
> powerful enough to handle this:

> # thread.c is needed only for non-WIN32 implementation of path.c
> ifneq ($(PORTNAME), win32)
> OBJS += thread.o
> endif

Hmm, sounds like a problem, but why was it not a problem before?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2007-10-01 03:51:11 Re: Latest ecpg patch broke MSVC build
Previous Message Andrew Dunstan 2007-10-01 03:30:35 Re: Latest ecpg patch broke MSVC build